[FIX] Test & Learn: handling memory error#2316
Merged
janezd merged 1 commit intobiolab:masterfrom May 25, 2017
jerneju:memory-testlearners
Merged
[FIX] Test & Learn: handling memory error#2316janezd merged 1 commit intobiolab:masterfrom jerneju:memory-testlearners
janezd merged 1 commit intobiolab:masterfrom
jerneju:memory-testlearners
Conversation
Contributor
Author
jerneju
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2316 +/- ##
==========================================
+ Coverage 73.24% 73.29% +0.05%
==========================================
Files 317 317
Lines 55366 55396 +30
==========================================
+ Hits 40553 40604 +51
+ Misses 14813 14792 -21 |
janezd
reviewed
May 20, 2017
| self.send_signal("Data", data) | ||
| self.assertFalse(self.widget.Error.memory_error.is_shown()) | ||
|
|
||
| with unittest.mock.patch("Orange.evaluation.testing.Results.get_augmented_data") as mocked: |
Contributor
There was a problem hiding this comment.
with unittest.mock.patch(
"Orange.evaluation.testing.Results.get_augmented_data",
side_effect=MemoryError) as mocked:
This way, it's more obvious why are you mocking.
| mocked.side_effect = MemoryError() | ||
| self.send_signal("Learner", MajorityLearner(), 0, wait=5000) | ||
|
|
||
| self.assertTrue(self.widget.Error.memory_error.is_shown()) |
Contributor
There was a problem hiding this comment.
Put this line inside with. Not because it doesn't work outside, but because with kind of groups the test.
Contributor
Author
|
Fixed. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://sentry.io/biolab/orange3/issues/218529776/
Description of changes
Includes