[FIX] Silhouette Plot: now setting axis range properly#2377
[FIX] Silhouette Plot: now setting axis range properly#2377janezd merged 2 commits intobiolab:masterfrom jerneju:exception-silhouette
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2377 +/- ##
=========================================
Coverage ? 74.33%
=========================================
Files ? 320
Lines ? 55828
Branches ? 0
=========================================
Hits ? 41497
Misses ? 14331
Partials ? 0 |
| def __setup(self): | ||
| # Setup the subwidgets/groups/layout | ||
| smax = max((numpy.max(g.scores) for g in self.__groups | ||
| smax = max((numpy.max(numpy.nan_to_num(g.scores)) for g in self.__groups |
There was a problem hiding this comment.
Why not numpy.nanmax (here) and numpy.nanmin (below)? Plus, set it to 1 or -1 if the length is zero or all values are NaN.
jerneju
changed the title
|
Is this still WIP, as the title suggests, or can we merge it? As a sidenote, the snapshot again provides no information (except that the bug can be reproduced by connecting Silhouette to File), so one has to check the code to see what the PR is about. No need to fix this here, but please provide meaningful descriptions in the future. |
|
You can add |
jerneju
changed the title
|
Ok, fixed. |
| @@ -1,3 +1,4 @@ | |||
| # pylint disable=protected-access | |||
There was a problem hiding this comment.
Sorry for my typeo: this has no effect due to a missing a colon after pylint (see below). You can also add a comment # Test methods are allowed to access private members above.
There was a problem hiding this comment.
Well, my mistake, I should have known by now that there is a colon after # pylint.
3 participants
Issue
Handling
nanvalues.https://sentry.io/biolab/orange3/issues/220334718/
Description of changes
Includes