Skip to content

[ENH] OWFeatureConstructor: Add new functions from numpy#2410

Merged
thocevar merged 2 commits intobiolab:masterfrom
lopezco:feature-constructor-add-functions
Aug 22, 2017
Merged

[ENH] OWFeatureConstructor: Add new functions from numpy#2410
thocevar merged 2 commits intobiolab:masterfrom
lopezco:feature-constructor-add-functions

Conversation

@lopezco
Copy link
Contributor

@lopezco lopezco commented Jun 19, 2017

Issue

Implements new functions

Description of changes
  • Add numpy 'nan' functions as replacement for min, max, sum
  • Add other functions: mean, std, var...
Includes
  • Code changes
  • Tests
  • Documentation

@lopezco lopezco changed the title OWFeatureConstructor: Add new functions from numpy [ENH] OWFeatureConstructor: Add new functions from numpy Jun 20, 2017
@thocevar thocevar self-assigned this Aug 18, 2017
@thocevar
Copy link
Contributor

Overriding sum with nansum is counterintuitive. In case of an unkown value the sum should be unkown as well. Consider adding nansum and others as separate functions.

Please rebase the branch to resolve conflicts and fix the pylint errors reported by Travis CI.

@codecov-io
Copy link

codecov-io commented Aug 21, 2017

Codecov Report

Merging #2410 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2410      +/-   ##
==========================================
- Coverage   75.11%   75.07%   -0.04%     
==========================================
  Files         323      323              
  Lines       56902    56903       +1     
==========================================
- Hits        42743    42722      -21     
- Misses      14159    14181      +22

@thocevar
Copy link
Contributor

There was a problem with your rebase. Most likely you rebased on a branch that was not synced with biolab:master and ended up with 100+ commits in the pull request. I'll handle the merge from here on, thank you for your contribution.

@lopezco
Copy link
Contributor Author

lopezco commented Aug 21, 2017

wow! sorry @thocevar you're right. I didn't check that

@thocevar thocevar merged commit 9ee3961 into biolab:master Aug 22, 2017
@lopezco lopezco deleted the feature-constructor-add-functions branch August 22, 2017 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants