Skip to content

[ENH] Canvas Annotations: Text markup editing#2422

Merged
astaric merged 5 commits intobiolab:masterfrom
ales-erjavec:canvas-annotations-rich-text
Jun 30, 2017
Merged

[ENH] Canvas Annotations: Text markup editing#2422
astaric merged 5 commits intobiolab:masterfrom
ales-erjavec:canvas-annotations-rich-text

Conversation

@ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Jun 22, 2017

Issue

Implements inline text markup editing for canvas annotations. Html, rst and markdown are supported.

Use alt-right click on the annotation to change how the content should be interpreted.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the canvas-annotations-rich-text branch from ef62ee4 to e3d0efd Compare June 23, 2017 07:38
@codecov-io
Copy link

codecov-io commented Jun 23, 2017

Codecov Report

Merging #2422 into master will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2422      +/-   ##
==========================================
+ Coverage   73.88%   74.23%   +0.35%     
==========================================
  Files         320      320              
  Lines       55828    55828              
==========================================
+ Hits        41247    41446     +199     
+ Misses      14581    14382     -199

@astaric
Copy link
Member

astaric commented Jun 26, 2017

IIUC, the Windows build fails because CommonMark is not available on conda?

@ales-erjavec ales-erjavec force-pushed the canvas-annotations-rich-text branch from e3d0efd to 570cc9b Compare June 27, 2017 07:55
@ales-erjavec
Copy link
Contributor Author

It failed because CommonMark was not listed in conda recipe.

Copy link
Member

@astaric astaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried it out and it works (I have mainly played around with markdown syntax)

The only thing I could not get to render were links in [Link](http://a.com) format, but IMHO it is not a dealbreaker.

@astaric astaric merged commit 5add0a5 into biolab:master Jun 30, 2017
@ales-erjavec ales-erjavec deleted the canvas-annotations-rich-text branch June 30, 2017 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants