[FIX] Add-ons: Fix Installation of Official Add-ons Through Drag & Drop#2481
Merged
lanzagar merged 1 commit intobiolab:masterfrom Jul 19, 2017
Merged
[FIX] Add-ons: Fix Installation of Official Add-ons Through Drag & Drop#2481lanzagar merged 1 commit intobiolab:masterfrom
lanzagar merged 1 commit intobiolab:masterfrom
Conversation
Installing official addons through drag & drop doesn work from cleaning the addons names onwards. The mismatch occurs when we compare cleaned addon name with the zip file name. Since the officical addon name was cleaned it doesn't match the uncleaned zip filename.
Contributor
|
Codecov Report
@@ Coverage Diff @@
## master #2481 +/- ##
==========================================
+ Coverage 74.51% 74.53% +0.02%
==========================================
Files 321 321
Lines 56056 56056
==========================================
+ Hits 41769 41784 +15
+ Misses 14287 14272 -15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Installing official add-ons through drag & drop doesn't work from cleaning the add-ons names onwards (3.4.0 onwards?). The mismatch occurs when we compare cleaned addon name with the zip file name. Since the official addon name was cleaned it doesn't match the uncleaned zip filename.
Description of changes
Clean the drag & drop file name in the same manner as official addons.
Includes