Skip to content

[FIX] MDS: Optimize similar pairs graphics construction#2536

Merged
janezd merged 2 commits intobiolab:masterfrom
ales-erjavec:fixes/mds-optimize-pairs
Sep 1, 2017
Merged

[FIX] MDS: Optimize similar pairs graphics construction#2536
janezd merged 2 commits intobiolab:masterfrom
ales-erjavec:fixes/mds-optimize-pairs

Conversation

@ales-erjavec
Copy link
Copy Markdown
Contributor

Issue

MDS similar pairs graphics construction was (unnecessarily) O(n**4).

Description of changes
  • Speedup graphics item construction
  • Replace use of individual QGraphicsItem for each line with a single PlotCurveItem
  • Limit the number of displayed pairs to 10000
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the fixes/mds-optimize-pairs branch from 0532a09 to 1f17ecb Compare August 25, 2017 13:40
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 25, 2017

Codecov Report

Merging #2536 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2536      +/-   ##
==========================================
- Coverage   75.13%   75.12%   -0.02%     
==========================================
  Files         324      324              
  Lines       56963    56964       +1     
==========================================
- Hits        42798    42793       -5     
- Misses      14165    14171       +6

@janezd janezd added this to the 3.4.6 milestone Sep 1, 2017
@janezd janezd merged commit afc6dc1 into biolab:master Sep 1, 2017
@ales-erjavec ales-erjavec deleted the fixes/mds-optimize-pairs branch November 14, 2017 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants