[FIX] widgets/tests: Compatibility with Python 3.5.{0,1}#2575
Merged
astaric merged 1 commit intobiolab:masterfrom Sep 11, 2017
Merged
[FIX] widgets/tests: Compatibility with Python 3.5.{0,1}#2575astaric merged 1 commit intobiolab:masterfrom
astaric merged 1 commit intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2575 +/- ##
==========================================
+ Coverage 75.02% 75.02% +<.01%
==========================================
Files 327 327
Lines 57639 57641 +2
==========================================
+ Hits 43246 43248 +2
Misses 14393 14393 |
typing.Type was introduced in Python 3.5.2
ales-erjavec
force-pushed
the
fixes/typing-compat
branch
from
8a09c79 to
24edd0c
Compare
Contributor
|
I'm stupid -- of course we don't need to import it if it's not there; it appears just in the comments. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
typing.Type was introduced only in Python 3.5.2
Description of changes
try-except the import.
Includes