[ENH] DomainEditor: Add horizontal header#2579
Merged
BlazZupan merged 1 commit intobiolab:masterfrom Sep 13, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2579 +/- ##
==========================================
+ Coverage 75.02% 75.03% +<.01%
==========================================
Files 327 327
Lines 57641 57646 +5
==========================================
+ Hits 43248 43252 +4
- Misses 14393 14394 +1 |
Contributor
|
Oh yes, I hated this, too! |
Contributor
Author
|
Codecov/patch failed since tests don't seem to go into I can obviously write a test that covers this line, but ... won't since there's nothing to test here. |
Contributor
Contributor
Author
|
I can't replicate this -- I can resize it. |
Contributor
|
Updated the master and now I can, too. Sorry for the panic. :O |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue
DomainEditor (e.g. in the File Widget) does not have horizontal header and hence doesn't allow the user to resize the columns. This is a problem when the features have longer names.
Description of changes
I added the header. While it is better in terms of functionality, the previous design may have been less cluttered. @BlazZupan, what do you think?
Includes