[FIX] OWBoxPlot: Faster selection#2595
Merged
astaric merged 1 commit intobiolab:masterfrom Sep 21, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
==========================================
+ Coverage 75.07% 75.07% +<.01%
==========================================
Files 327 327
Lines 57723 57723
==========================================
+ Hits 43336 43338 +2
+ Misses 14387 14385 -2 |
kernc
reviewed
Sep 18, 2017
| if inst in selected] | ||
| selected_ids = set(selected.ids) | ||
| selection = [i for i, id in enumerate(self.dataset.ids) | ||
| if id in selected_ids] |
Contributor
There was a problem hiding this comment.
How about:
selection = np.in1d(self.dataset.ids, selected.ids).nonzero()[0]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Selection of instances in Box Plot had complexity O(n_all * n_selected), making it too slow / freeze for data with a couple thousand instances.
Description of changes
Use faster membership testing.
Includes