[FIX] setup: Increase required setuptools version#2602
Merged
astaric merged 1 commit intobiolab:masterfrom Sep 20, 2017
Merged
Conversation
jerneju
approved these changes
Sep 20, 2017
This is required for installing namespace packages from wheels build with newer versions of setuptools (see setuptools issue 885) Fixes biolabgh-2600
ales-erjavec
force-pushed
the
macos-application-setuptools
branch
from
f12755d to
06ee728
Compare
Codecov Report
@@ Coverage Diff @@
## master #2602 +/- ##
=======================================
Coverage 75.09% 75.09%
=======================================
Files 329 329
Lines 57773 57773
=======================================
Hits 43386 43386
Misses 14387 14387 |
Member
|
@ales-erjavec Do we also need to update the conda-spec file? |
Contributor
Author
|
It would be better to update conda-recipe/meta.yaml as well as the conda-forge one. The conda-spec.txt is (an example of) a generated file. The env spec is otherwise rebuild when the installers get created. |
Member
|
Ok. I'll update the conda-forge recipe when we do the 3.6 release (probably this friday). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-2600
Description of changes
Increase required setuptools version to 36.3
This is required for installing namespace packages from wheels
build with newer versions of setuptools (see setuptools issue 885)
Includes