[FIX] settings: Store settings version in the serialized defaults#2631
Merged
astaric merged 2 commits intobiolab:masterfrom Sep 29, 2017
Merged
[FIX] settings: Store settings version in the serialized defaults#2631astaric merged 2 commits intobiolab:masterfrom
astaric merged 2 commits intobiolab:masterfrom
Conversation
Contributor
Codecov Report
@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
+ Coverage 75.01% 75.18% +0.17%
==========================================
Files 331 331
Lines 58109 57796 -313
==========================================
- Hits 43588 43456 -132
+ Misses 14521 14340 -181 |
jerneju
approved these changes
Sep 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Widget settings version were not stored in the serialized defaults, but were still passed to OWWidget.migrate_settings with an incorrect version of 0.
One example where this caused an error (due to wrong migration)
Description of changes
Store settings version in the serialized defaults.
Includes