Skip to content

[FIX] canvas/stackedwidget: Check if the new geometry is the same as the old#2636

Merged
astaric merged 1 commit intobiolab:masterfrom
ales-erjavec:canvas/stacklayout-recursion
Sep 29, 2017
Merged

[FIX] canvas/stackedwidget: Check if the new geometry is the same as the old#2636
astaric merged 1 commit intobiolab:masterfrom
ales-erjavec:canvas/stacklayout-recursion

Conversation

@ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Sep 28, 2017

Issue

(Maybe) Fixes gh-2614

Description of changes

Check if the new geometry is the same as the old. Do nothing if they are the same.

Includes
  • Code changes
  • Tests
  • Documentation

Do nothing if they are the same. This is to prevent a possible
infinite recursion.

Equivalent-to: biolab/orange-canvas-core@0fa9053
@codecov-io
Copy link

Codecov Report

Merging #2636 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2636   +/-   ##
=======================================
  Coverage   75.17%   75.17%           
=======================================
  Files         331      331           
  Lines       57769    57769           
=======================================
  Hits        43429    43429           
  Misses      14340    14340

@astaric astaric added this to the 3.6 milestone Sep 29, 2017
@astaric astaric merged commit 7753e1b into biolab:master Sep 29, 2017
@ales-erjavec ales-erjavec deleted the canvas/stacklayout-recursion branch November 14, 2017 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants