Skip to content

[FIX] Scatter Plot: Scatter Plot automatically sends selection #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janezd merged 1 commit into from
Oct 13, 2017
Merged

[FIX] Scatter Plot: Scatter Plot automatically sends selection #2649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Orange/widgets/visualize/owscatterplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ def update_graph(self, reset_view=True, **_):
self.graph.update_data(self.attr_x, self.attr_y, reset_view)

def selection_changed(self):
self.send_data()
self.commit()

def send_data(self):
selected = None
Expand Down
15 changes: 15 additions & 0 deletions Orange/widgets/visualize/tests/test_owscatterplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,21 @@ def test_vizrank(self):
states = [state for state in vizrank.iterate_states(None)]
self.assertIsNotNone(vizrank.compute_score(states[0]))

def test_auto_send_selection(self):
"""
Scatter Plot automatically sends selection only when the checkbox Send automatically
is checked.
GH-2649
GH-2646
"""
data = Table("iris")
self.send_signal(self.widget.Inputs.data, data)
self.widget.controls.auto_send_selection.setChecked(False)
self.assertEqual(False, self.widget.controls.auto_send_selection.isChecked())
self._select_data()
self.assertIsNone(self.get_output(self.widget.Outputs.selected_data))
self.widget.controls.auto_send_selection.setChecked(True)
self.assertIsInstance(self.get_output(self.widget.Outputs.selected_data), Table)


if __name__ == "__main__":
Expand Down