[FIX] Silhouette plot rendering#2656
Merged
janezd merged 2 commits intobiolab:masterfrom Oct 13, 2017
Merged
Conversation
The scene rect was not adjusted properly when decreasing the bar size height.
Codecov Report
@@ Coverage Diff @@
## master #2656 +/- ##
==========================================
- Coverage 75.45% 75.44% -0.02%
==========================================
Files 331 331
Lines 57970 58022 +52
==========================================
+ Hits 43742 43775 +33
- Misses 14228 14247 +19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Rendering issues due to QTBUG-55070:
Description of changes
Remove use of QGraphicsProxyWidget. Also tweak scene rect update which did not update properly when decreasing the bar height.
Includes