[FIX] Report Table: Make Table Headers Bold

[nikicc]

Issue

When reporting a view (or model?) through report_table header column and row is printed in the same format as the data values. Although there is a code that mark header columns as <th> (and not as <td>) this is invalidated by the font-weight attribute.

E.g. in Test & Score before:

and after:

Description of changes

Set font-weight to bold when inside header so <th> is not invalidated.

Includes

• Code changes
• Tests
• Documentation

[kernc]

Default HTML style sheets must have changed. I'm sure headers were bold before.

[janezd]

I like the change. But what if we changed the style definition for the th tag instead? The tag is used in several places and I suppose that we'd always like to have it bold.

[codecov-io]

Codecov Report

Merging #2668 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2668   +/-   ##
=======================================
  Coverage   75.51%   75.51%           
=======================================
  Files         332      332           
  Lines       58014    58014           
=======================================
  Hits        43812    43812           
  Misses      14202    14202

[nikicc]

I like the change. But what if we changed the style definition for the th tag instead? The tag is used in several places and I suppose that we'd always like to have it bold.

I agree. Please, check again.

[janezd]

Could we avoid !important? I think the culprit is (report.py, line 244)

weight = 'bold' if font and font.bold() else 'normal'.

What if we had

weight = 'font-weight: bold;' if font and font.bold() else ''

and then replace 'font-weight:{weight};' with {weight}? That is, skip font-weight property when it is not bold?

Another benefit from this would be that our HTML would look a small tad less like it was generated by Word. :)

[nikicc]

Fixed, please check again.