[FIX] Outliers widget no longer checks classes and doesn't crash on singular covariances matrices#2677
Merged
jerneju merged 3 commits intobiolab:masterfrom Oct 20, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2677 +/- ##
==========================================
- Coverage 75.65% 75.65% -0.01%
==========================================
Files 333 333
Lines 58422 58418 -4
==========================================
- Hits 44202 44197 -5
- Misses 14220 14221 +1 |
jerneju
reviewed
Oct 18, 2017
| class EllipticEnvelopeLearner(SklLearner): | ||
| __wraps__ = skl_covariance.EllipticEnvelope | ||
| __returns__ = EllipticEnvelopeClassifier | ||
| preprocessors = [Continuize(), RemoveNaNColumns(), SklImpute()] |
Contributor
There was a problem hiding this comment.
Where are these preprocessors used?
jerneju
approved these changes
Oct 20, 2017
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
EllipticEnvelopeLearnerremoves instances without classes.Fixes #2588.
Description of changes
EllipticEnvelopeLearnerTests do not add much new; they passed before, too. The PR actually removes tests that checked for what shouldn't had been checked.
Includes