Conversation
ales-erjavec
left a comment
ales-erjavec
left a comment
There was a problem hiding this comment.
There is also a short test in https://github.com/biolab/orange-bio/blob/master/orangecontrib/bio/widgets3/utils/gui.py#L532 that you can add
Orange/widgets/data/owdatasets.py
Outdated
| self.completer = TokenListCompleter( | ||
| self, caseSensitivity=Qt.CaseInsensitive | ||
| ) | ||
| self.filterLineEdit.setCompleter(self.completer) |
There was a problem hiding this comment.
The completer is not actually used? There is no completion model set after this.
There was a problem hiding this comment.
Oops, you are right. I started moving functionality from GEO Datasets, but then changed to a simpler version. No caching from MySortFilterProxyModel and no completion. It actually seemed good enough for now. I haven't tested when caching would become important, but there are no performance problems for now (and probably won't be in the near future for a manually curated list of data sets). We might want to consider enabling/finishing completion (since it is already done in bioinf.), however, we can also go with a bare-bones approach (and remove moving that class for now) => less code, easier to maintain?
@ales-erjavec are the two related? Does adding a completer require the use of caching (probably should not be the case) or was there another reason for that in GEO (more data sets, automatically synced with a big external repository)?
There was a problem hiding this comment.
Are the two related? Does adding a completer require the use of caching.
No.
Codecov Report
@@ Coverage Diff @@
## master #2695 +/- ##
==========================================
+ Coverage 75.83% 75.89% +0.06%
==========================================
Files 338 338
Lines 59566 59594 +28
==========================================
+ Hits 45173 45230 +57
+ Misses 14393 14364 -29 |
lanzagar
force-pushed
the
datasets_filter
branch
from
9dc328e to
3dcbc9b
Compare
5 participants
Issue
Filtering of data sets was not supported.
Description of changes
Partially reuse filtering from GEO Data Sets (Orange-Bioinformatics). Includes pulling the class TokenListCompleter to core Orange and using it in owdatasets.
Includes