Statistics.stack: Move to statistics module#2696
Statistics.stack: Move to statistics module#2696pavlin-policar wants to merge 1 commit intobiolab:masterfrom
Conversation
| import numpy as np | ||
| import bottleneck as bn | ||
| from scipy import sparse as sp | ||
| import numpy as np |
There was a problem hiding this comment.
Add
from Orange.statistics.util import hstack, vstack # back-compatd2286a4 to
86ef0f9
Compare
|
Hmmm ... I like that we have everything together but importing Perhaps, should we introduce a separate module for this sparse/dense compatibility methods? Some other methods from |
fca1dd7 to
18c0a06
Compare
|
I agree, Of course, we'd have to move a large number of functions from there. |
79a6bf9 to
2a7c36d
Compare
2a7c36d to
e3db39a
Compare
|
This had conflicts and it would be easier to simply start fresh from master, since the changes in this PR were quite trivial. We had decided that it would be strange to have common functions (such as |
Issue
hstackandvstackexisted inOrange.data.util, however all the other functions that handle sparse and dense data are situated inOrange.statistics.util.Description of changes
Move functions and tests to
Orange.statistics.utilmodule to keep all functions that deal with sparse/dense compatibility in same module.Based on #2572.
Includes