[FIX] ScatterPlot Crashes on Data With Infinity Values#2709
Merged
markotoplak merged 2 commits intobiolab:masterfrom Oct 27, 2017
jerneju:spg-inf
Merged
[FIX] ScatterPlot Crashes on Data With Infinity Values#2709markotoplak merged 2 commits intobiolab:masterfrom jerneju:spg-inf
markotoplak merged 2 commits intobiolab:masterfrom
jerneju:spg-inf
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2709 +/- ##
==========================================
+ Coverage 76.02% 76.03% +<.01%
==========================================
Files 338 338
Lines 59604 59615 +11
==========================================
+ Hits 45315 45328 +13
+ Misses 14289 14287 -2 |
kernc
suggested changes
Oct 24, 2017
Orange/widgets/utils/scaling.py
Outdated
| self.original_data = np.hstack((data.X, Y)).T | ||
| self.scaled_data = no_jit = self.original_data.copy() | ||
| self.valid_data_array = ~np.isnan(no_jit) | ||
| self.valid_data_array = ~np.isnan(no_jit) & ~np.isinf(no_jit) |
Contributor
There was a problem hiding this comment.
self.valid_data_array = np.isfinite(no_jit)
kernc
reviewed
Oct 24, 2017
Orange/widgets/tests/base.py
Outdated
| def data_one_column_infs(cls): | ||
| table = cls.data_one_column_nans() | ||
| table.X[:, 1] = np.inf | ||
| return table |
Contributor
There was a problem hiding this comment.
Could extend data_one_column_nans() into data_one_column_vals(value=np.nan) and call as data_one_column_vals(np.inf).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes # #2684 .
Description of changes
Includes