[FIX] errorreporting: Remove use of pip internal api#2724
Merged
kernc merged 2 commits intobiolab:masterfrom Oct 30, 2017
Merged
[FIX] errorreporting: Remove use of pip internal api#2724kernc merged 2 commits intobiolab:masterfrom
kernc merged 2 commits intobiolab:masterfrom
Conversation
Pip 10 will move all internal APIs.
Codecov Report
@@ Coverage Diff @@
## master #2724 +/- ##
==========================================
+ Coverage 76.03% 76.03% +<.01%
==========================================
Files 338 338
Lines 59628 59628
==========================================
+ Hits 45339 45341 +2
+ Misses 14289 14287 -2 |
jerneju
reviewed
Oct 30, 2017
Contributor
There was a problem hiding this comment.
Traceback (most recent call last):
File "/venv/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2459, in version
return self._version
File "/venv/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2545, in __getattr__
raise AttributeError(attr)
AttributeError: _version
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/orange3/Orange/canvas/application/errorreporting.py", line 245, in handle_exception
return ErrorReporting.handle_exception(exc)
File "/usr/lib/python3.5/unittest/mock.py", line 1157, in patched
return func(*args, **keywargs)
File "/orange3/Orange/canvas/application/errorreporting.py", line 195, in handle_exception
for dist in pkg_resources.working_set))
File "/orange3/Orange/canvas/application/errorreporting.py", line 195, in <genexpr>
for dist in pkg_resources.working_set))
File "/venv/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2464, in version
raise ValueError(tmpl % self.PKG_INFO, self)
ValueError: ("Missing 'Version:' header and/or PKG-INFO file", Orange [unknown version] (/orange3))
-------------------------------------------------------------------------------
Fatal Python error: Cannot recover from stack overflow.
Contributor
Author
|
Which version of setuptools do you have installed ( How was orange3 installed and what does |
Contributor
|
|
As documented accessing `version` can raise ValueError.
Contributor
Author
|
I was unable to duplicate the error, but the error is part of the documented Distribution.version behavior. |
jerneju
approved these changes
Oct 30, 2017
Contributor
jerneju
left a comment
There was a problem hiding this comment.
Now it does not crash and a list of installed packages with their versions is sent to the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Error reporting uses internal pip api, which will be moved in Pip 10.
Description of changes
Remove use of pip internal api
Includes