Skip to content

[FIX] Test & Learn: do not crash on a data with class only nans #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lanzagar merged 1 commit into from
Nov 28, 2017
Merged

[FIX] Test & Learn: do not crash on a data with class only nans #2751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Orange/widgets/evaluate/owtestlearners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ class Error(OWWidget.Error):
class_inconsistent = Msg("Test and train data sets "
"have different target variables.")
memory_error = Msg("Not enough memory.")
no_class_values = Msg("Target variable has no values.")
only_one_class_var_value = Msg("Target variable has only one value.")

class Warning(OWWidget.Warning):
Expand Down Expand Up @@ -356,16 +357,19 @@ def set_train_data(self, data):
self.Error.train_data_empty.clear()
self.Error.class_required.clear()
self.Error.too_many_classes.clear()
self.Error.no_class_values.clear()
self.Error.only_one_class_var_value.clear()
if data is not None and not len(data):
self.Error.train_data_empty()
data = None
if data:
conds = [not data.domain.class_vars,
len(data.domain.class_vars) > 1,
np.isnan(data.Y).all(),
data.domain.has_discrete_class and len(data.domain.class_var.values) == 1]
errors = [self.Error.class_required,
self.Error.too_many_classes,
self.Error.no_class_values,
self.Error.only_one_class_var_value]
for cond, error in zip(conds, errors):
if cond:
Expand Down
15 changes: 15 additions & 0 deletions Orange/widgets/evaluate/tests/test_owtestlearners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,21 @@ def test_one_class_value(self):
self.send_signal("Learner", MajorityLearner(), 0, wait=1000)
self.assertTrue(self.widget.Error.only_one_class_var_value.is_shown())

def test_nan_class(self):
"""
Do not crash on a data with only nan class values.
GH-2751
"""
def assertErrorShown(data, is_shown):
self.send_signal("Data", data)
self.assertEqual(is_shown, self.widget.Error.no_class_values.is_shown())

data = Table("iris")[::30]
data.Y[:] = np.nan

for data, is_shown in zip([None, data, Table("iris")[:30]], [False, True, False]):
assertErrorShown(data, is_shown)

def test_addon_scorers(self):
try:
class NewScore(Score):
Expand Down