Skip to content

[ENH] Canvas: Improve preview rendering#2784

Merged
astaric merged 2 commits intobiolab:masterfrom
ales-erjavec:canvas/preview-rendering
Dec 20, 2017
Merged

[ENH] Canvas: Improve preview rendering#2784
astaric merged 2 commits intobiolab:masterfrom
ales-erjavec:canvas/preview-rendering

Conversation

@ales-erjavec
Copy link
Copy Markdown
Contributor

Issue

Old sins die hard.

Description of changes
  • Render preview icons without writing the svg to disk
  • Strip the node 'properties' from the .ows before parsing for preview rendering.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2784 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2784   +/-   ##
=======================================
  Coverage   76.09%   76.09%           
=======================================
  Files         338      338           
  Lines       59723    59723           
=======================================
  Hits        45444    45444           
  Misses      14279    14279

@astaric astaric merged commit 4f52866 into biolab:master Dec 20, 2017
@ales-erjavec ales-erjavec deleted the canvas/preview-rendering branch December 20, 2017 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants