[FIX][ENH] Scatter Plot VizRank: some fixes and regard to color#2787
Merged
lanzagar merged 2 commits intobiolab:masterfrom Nov 27, 2017
jerneju:scatterplot-vizrank
Merged
[FIX][ENH] Scatter Plot VizRank: some fixes and regard to color#2787lanzagar merged 2 commits intobiolab:masterfrom jerneju:scatterplot-vizrank
lanzagar merged 2 commits intobiolab:masterfrom
jerneju:scatterplot-vizrank
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2787 +/- ##
=========================================
+ Coverage 76.1% 76.1% +<.01%
=========================================
Files 338 338
Lines 59760 59767 +7
=========================================
+ Hits 45479 45486 +7
Misses 14281 14281 |
use variables instead of indices where possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2037
Description of changes
2) Usescombinationsfromitertools.3) Now it uses variables instead of indices.Also added one test to increase coverage (test method
row_for_state). Sadly code coverage is not measured when running a code in a thread and that is why test calls this specific method.Includes