[ENH] New signals: Trees, Forest#2801
Merged
lanzagar merged 3 commits intobiolab:masterfrom Nov 30, 2017
jerneju:new-signals-trees
Merged
[ENH] New signals: Trees, Forest#2801lanzagar merged 3 commits intobiolab:masterfrom jerneju:new-signals-trees
lanzagar merged 3 commits intobiolab:masterfrom
jerneju:new-signals-trees
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2801 +/- ##
==========================================
+ Coverage 76.16% 76.17% +<.01%
==========================================
Files 338 338
Lines 59879 59910 +31
==========================================
+ Hits 45606 45635 +29
- Misses 14273 14275 +2 |
jerneju
changed the title
nikicc
approved these changes
Nov 29, 2017
Contributor
nikicc
left a comment
nikicc
left a comment
There was a problem hiding this comment.
Looks good to me.
Though, I have one minor comment. IMHO
self.widget.Inputs.tree
is better, cleaner and not that much longer than
w = self.widget
w.Input.tree
But it might be just a personal preference.
Contributor
|
@lanzagar I suggest we merge this, if you still allow merging before the release. |
Contributor
|
I agree introducing another variable and line of code is often not worth it just to save a few characters in a couple of lines after that. But it is a matter of preference and not a big issue so I would prefer not to wait with merging until the last minutes before a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2797
Description of changes
Tree Viewer
Pythagorean Tree
Pythagorean Forest
Geo MapIncludes