[ENH] Scatter Plot Graph: legend opacity#2819
Merged
lanzagar merged 2 commits intobiolab:masterfrom Dec 11, 2017
jerneju:spg-legend-opacity
Merged
[ENH] Scatter Plot Graph: legend opacity#2819lanzagar merged 2 commits intobiolab:masterfrom jerneju:spg-legend-opacity
lanzagar merged 2 commits intobiolab:masterfrom
jerneju:spg-legend-opacity
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
=========================================
Coverage ? 80.77%
=========================================
Files ? 324
Lines ? 56221
Branches ? 0
=========================================
Hits ? 45413
Misses ? 10808
Partials ? 0 |
jerneju
changed the title
janezd
reviewed
Dec 8, 2017
Contributor
janezd
left a comment
janezd
left a comment
There was a problem hiding this comment.
Just a bit of nitpicking. Otherwise OK.
| for i, value in enumerate(self.attr_color.values): | ||
| color = QColor(*palette.getRGB(i)) | ||
| brush = color.lighter(self.DarkerValue) | ||
| pen = make_pen(QColor(color).darker(self.DarkerValue), 1.5) |
Contributor
There was a problem hiding this comment.
pen = make_pen(color.darker(self.DarkerValue), 1.5), without QColor.
| _define_symbols() | ||
|
|
||
|
|
||
| def make_pen(color, width): |
Contributor
There was a problem hiding this comment.
I suppose we should better name it _make_pen, so we don't commit to keeping this function. Otherwise some add-on could rely on it.
make_pen -> _make_pen
Contributor
Author
|
@janezd : you can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
See #2804 (review) fourth bullet.
Description of changes
Take a look at Opacity Slider, Legend, and points!
Includes