[ENH] Linear Discriminant Analysis: scripting part#2823
Merged
markotoplak merged 2 commits intobiolab:masterfrom Jan 19, 2018
jerneju:lda
Merged
[ENH] Linear Discriminant Analysis: scripting part#2823markotoplak merged 2 commits intobiolab:masterfrom jerneju:lda
markotoplak merged 2 commits intobiolab:masterfrom
jerneju:lda
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2823 +/- ##
==========================================
- Coverage 82.09% 82.07% -0.02%
==========================================
Files 327 328 +1
Lines 56166 56155 -11
==========================================
- Hits 46107 46092 -15
- Misses 10059 10063 +4 |
jerneju
changed the title
markotoplak
reviewed
Jan 18, 2018
Orange/projection/lda.py
Outdated
| __all__ = ["LDA"] | ||
|
|
||
|
|
||
| class _FeatureScorerMixin(LearnerScorer): |
Member
There was a problem hiding this comment.
Is this mixin exactly the same as with PCA? If so, why is a separate one used?
Orange/projection/lda.py
Outdated
| super().__init__(lda_transform) | ||
| self.projection = projection | ||
| self.feature = feature | ||
| self.transformed = None |
Member
There was a problem hiding this comment.
Who uses "transformed" and "projection"? Why are these here?
Orange/projection/lda.py
Outdated
| compute_value=LDAProjector(self, i, lda_transform)) | ||
| v.to_sql = LinearCombinationSql( | ||
| domain.attributes, self.components_[i, :], | ||
| getattr(self, 'mean_', None)) |
Member
There was a problem hiding this comment.
Did you test the sql variant?
Contributor
|
Also, needs a rebase before merging... |
markotoplak
reviewed
Jan 19, 2018
Orange/tests/test_lda.py
Outdated
| @classmethod | ||
| def setUpClass(cls): | ||
| cls.ionosphere = Table('ionosphere') | ||
| cls.iris = Table('iris') |
Member
There was a problem hiding this comment.
Can you remove unused files too? Sorry for not noticing this before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No Linear Discriminant Analysis projection scripting part.
Description of changes
Scripting part written like PCA or FreeViz.
Includes