Skip to content

[FIX] mssql: Catch errors due to incorrect connection params #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astaric merged 1 commit into from
Dec 22, 2017
Merged

[FIX] mssql: Catch errors due to incorrect connection params #2838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Orange/data/sql/backend/mssql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ def __init__(self, connection_params):
self.connection = pymssql.connect(login_timeout=5, **connection_params)
except pymssql.Error as ex:
raise BackendError(str(ex)) from ex
except ValueError:
# ValueError is raised when 'server' contains "\\"
raise BackendError("Incorrect format of connection details")

def list_tables_query(self, schema=None):
return """
Expand Down