[FIX] OWWidget: Move 'splitter' to private members#2847
Merged
janezd merged 1 commit intobiolab:masterfrom Jan 8, 2018
Merged
Conversation
'splitter' is to generic name that can be (and is) used by subclasses that now (since biolabgh-2743) raise an "AttributeError: 'QSplitter' object has no attribute 'setControlAreaVisible'" in `OWWidget.showEvent`
ales-erjavec
force-pushed
the
fixes/widget-splitter-name
branch
from
508ee59 to
d3bbba5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2847 +/- ##
=========================================
Coverage ? 81.91%
=========================================
Files ? 326
Lines ? 56000
Branches ? 0
=========================================
Hits ? 45872
Misses ? 10128
Partials ? 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Since gh-2743 Data Sets, Predictions and GO Browser (from Bioinformatics add-on) raise a
Because they assign
self.splitter = ...Description of changes
Rename
OWWidget.splittertoOWWidget.__splitterIncludes