Skip to content

[FIX] Projection widgets: transform data properly#2871

Merged
lanzagar merged 3 commits intobiolab:masterfrom
jerneju:projections-transform
Jan 19, 2018
Merged

[FIX] Projection widgets: transform data properly#2871
lanzagar merged 3 commits intobiolab:masterfrom
jerneju:projections-transform

Conversation

@jerneju
Copy link
Contributor

@jerneju jerneju commented Jan 15, 2018

Issue

Thanks to @markotoplak and his new widget (biolab/orange3-prototypes#117) a new issue has been found.

Data in widgets Radviz, FreeViz, and Linear Projection is not transformed properly. Data indices are not preserved.

Description of changes

Use Table.transform.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #2871 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2871      +/-   ##
==========================================
+ Coverage   81.91%   81.91%   +<.01%     
==========================================
  Files         326      326              
  Lines       55997    56003       +6     
==========================================
+ Hits        45868    45874       +6     
  Misses      10129    10129

@jerneju jerneju changed the title [WIP] [FIX] Projection widgets: transform data properly [FIX] Projection widgets: transform data properly Jan 19, 2018
@lanzagar lanzagar added this to the 3.10 milestone Jan 19, 2018
@lanzagar lanzagar merged commit b6a3557 into biolab:master Jan 19, 2018
@jerneju jerneju deleted the projections-transform branch January 22, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants