[FIX] listfilter: Fix filter line edit completion#2896
Merged
astaric merged 2 commits intobiolab:masterfrom Jun 1, 2018
Merged
[FIX] listfilter: Fix filter line edit completion#2896astaric merged 2 commits intobiolab:masterfrom
astaric merged 2 commits intobiolab:masterfrom
Conversation
Make QCompleter a child of the filter line edit.
Codecov Report
@@ Coverage Diff @@
## master #2896 +/- ##
==========================================
+ Coverage 82.12% 82.37% +0.25%
==========================================
Files 329 335 +6
Lines 56258 57955 +1697
==========================================
+ Hits 46201 47742 +1541
- Misses 10057 10213 +156 |
Contributor
|
This results in the filter line auto-completing to the first hit and the box below shows only that one feature... If the filter box shows the first hit, I would expect to see all matching variables in the box below, until pressing enter when the auto-complete suggestion is accepted. |
Contributor
|
Any suggestions on how to implement completion so as not to interfere with regular filtering tasks? |
Member
|
The completion now only works on variable attributes, so it has no effect on regular filtering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Inline filter completion in the Select Columns widget does not work.
Description of changes
Make QCompleter a child of the filter line edit.
Includes