Merged
Conversation
ales-erjavec
force-pushed
the
io-speed
branch
from
27007d3 to
e398098
Compare
Codecov Report
@@ Coverage Diff @@
## master #2923 +/- ##
==========================================
- Coverage 81.86% 81.86% -0.01%
==========================================
Files 329 329
Lines 56770 56792 +22
==========================================
+ Hits 46474 46491 +17
- Misses 10296 10301 +5 |
Do not mix NaN float values in array of strings. Use single NA mask instead of always checking for NaN. Optimize out global or builtins loads where appropriate.
... if number of distinct discrete values is ~= number of rows Fixes biolabgh-1297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Includes