Skip to content

[FIX] Vizrank: Properly shutdown/wait when parent deleted #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markotoplak merged 2 commits into from
Mar 19, 2018
Merged

[FIX] Vizrank: Properly shutdown/wait when parent deleted #2960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce9776
vizrank: Properly shutdown/wait
ales-erjavec Nov 23, 2017
a018fd6
vizrank: Make sure the dialog has a parent
ales-erjavec Nov 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Orange/widgets/visualize/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class Information(WidgetMessagesMixin.Information):

def __init__(self, master):
"""Initialize the attributes and set up the interface"""
QDialog.__init__(self, windowTitle=self.captionTitle)
QDialog.__init__(self, master, windowTitle=self.captionTitle)
WidgetMessagesMixin.__init__(self)
self.setLayout(QVBoxLayout())

Expand Down Expand Up @@ -182,6 +182,10 @@ def hideEvent(event):

def deleteEvent():
vizrank.keep_running = False
if vizrank._thread is not None and vizrank._thread.isRunning():
vizrank._thread.quit()
vizrank._thread.wait()

master_delete_event()

master.closeEvent = closeEvent
Expand Down