Skip to content

[FIX] Fix reading double quoted text fields#2989

Merged
kernc merged 3 commits intobiolab:masterfrom
ales-erjavec:fixes/io-quoted
Apr 6, 2018
Merged

[FIX] Fix reading double quoted text fields#2989
kernc merged 3 commits intobiolab:masterfrom
ales-erjavec:fixes/io-quoted

Conversation

@ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Apr 6, 2018

Issue

Fixes gh-2293 and fixes gh-2956

Description of changes
  • Increase the sample for csv dialect inference
  • Use only the delimiter and quotechar from the inferred dialect.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #2989 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
+ Coverage   81.88%   81.88%   +<.01%     
==========================================
  Files         329      329              
  Lines       56866    56867       +1     
==========================================
+ Hits        46563    46564       +1     
  Misses      10303    10303

@kernc kernc merged commit d1b60f2 into biolab:master Apr 6, 2018
@PrimozGodec PrimozGodec added this to the 3.13 milestone Apr 17, 2018
@ales-erjavec ales-erjavec deleted the fixes/io-quoted branch April 24, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reading Saved Files: File + Save Data widget Orange Canvas Shall handle dirty data containing Double-Double Quotes

4 participants