[FIX] Feature constructor did not restore features when loading from saved workflow#2996
Merged
lanzagar merged 2 commits intobiolab:masterfrom May 11, 2018
Merged
Conversation
Update context matching to correctly match expressions that contain builtin functions and/or variables with comlpex names.
Codecov Report
@@ Coverage Diff @@
## master #2996 +/- ##
==========================================
+ Coverage 81.88% 81.89% +0.01%
==========================================
Files 329 329
Lines 56867 56879 +12
==========================================
+ Hits 46564 46583 +19
+ Misses 10303 10296 -7 |
lanzagar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When feature expression in feature constructor widget contained anything else than simple variable names, they were not restored when opening a saved workflow.
Description of changes
Update matching logic to support variable names containing special characters and usage of builtin functions.
Includes