[ENH] Combo Box Search Filter by ales-erjavec · Pull Request #3014 · biolab/orange3

ales-erjavec · 2018-04-20T15:37:29Z

Issue

Implements gh-2972

Description of changes

Implement a QComboBox, such that the displayed popup list view implements text search.
Use it in 'Hierarchical Clustering' widget as an example.

Includes

Code changes
Tests
Documentation

BlazZupan · 2018-04-20T17:56:22Z

Great prototype, works fast! Thanks.

On mouse over the fields, the selection (on mac, the coloring of the line indicating current position in the list) does not change. Following is an example of how this works for selection of linkage:

and how the line for Zzz3 is not marked with blue for selection of annotation:

Filter looks like an text entry box. When I first open the menu, I wanted to click somewhere inside the box to activate it and have the caret show, but action closes the pull down menu. I understand that the problem is with deciding which Qt widget is in focus. @markotoplak, @astaric, can you look at this and comment.

codecov-io · 2018-04-23T11:08:29Z

Codecov Report

Merging #3014 into master will increase coverage by 0.06%.
The diff coverage is 92.71%.

@@            Coverage Diff             @@
##           master    #3014      +/-   ##
==========================================
+ Coverage   82.64%   82.71%   +0.06%     
==========================================
  Files         342      342              
  Lines       59016    59062      +46     
==========================================
+ Hits        48774    48851      +77     
+ Misses      10242    10211      -31

ajdapretnar · 2018-06-29T11:47:00Z

This works really well for me. Something we could merge soon?

thocevar

Works great for me as well. We have to start using this component in other widgets to discover and fix any hidden bugs.

thocevar · 2018-08-03T07:56:36Z

Orange/widgets/utils/combobox.py

+
+    Behaves like a 'windows' styled combo box (i.e.
+    `styleHint(SH_ComboBoxPopup)` is False, but
+    the


I suppose this should continue.

thocevar · 2018-08-03T08:57:34Z

Orange/widgets/utils/combobox.py

+                return False
+            elif key in (Qt.Key_End, Qt.Key_Home) \
+                    and not modifiers & Qt.ControlModifier:
+                return False


I would prefer to have home/end key jump around on the search line when editing the query.

lanzagar · 2018-08-03T11:00:35Z

It is indeed great.
I suggest we merge this right after the current release and start adding it to widgets so that the next release has a batch of new combo boxes.
Both of @thocevar's comments make sense, I would also like to see home/end move the cursor where I am typing. But tweaks can also be made later, this has been open for too long already, so I don't mind merging even as it is now.

Segfaults on headless xcb.

Could segfault if the tested popup loses focus (is hidden and deleted) due to external factors. It is now run without any delay in the mouse event dispatch.

The popup does not appear to hide automatically on windows when a mouse button is pressed outside the popup window.

Remove special casing Home/End key filter, dispatch directly to the line edit with no event propagation up the parent chain.

ales-erjavec · 2018-08-09T13:01:13Z

Can you please test Home/End keys again to ensure they correspond to standard platform behavior.

thocevar · 2018-08-10T08:11:47Z

Home/End keys work on windows.

lanzagar · 2018-08-10T08:21:27Z

Works on linux too. Looks good to merge.

ales-erjavec force-pushed the combobox-search-filter branch 2 times, most recently from 7445f41 to 0385d51 Compare April 26, 2018 07:30

ales-erjavec force-pushed the combobox-search-filter branch from 0385d51 to 3bdbec5 Compare May 11, 2018 14:17

ales-erjavec force-pushed the combobox-search-filter branch from 3bdbec5 to ea1f83b Compare May 24, 2018 13:20

BlazZupan self-assigned this Jul 6, 2018

ales-erjavec changed the title ~~[RFC][ENH] Combo Box Search Filter~~ [ENH] Combo Box Search Filter Jul 6, 2018

ales-erjavec force-pushed the combobox-search-filter branch from 34c5fa3 to daec31b Compare July 6, 2018 11:52

thocevar self-requested a review August 3, 2018 07:43

thocevar approved these changes Aug 3, 2018

View reviewed changes

lanzagar added this to the 3.16 milestone Aug 3, 2018

ales-erjavec added 16 commits August 9, 2018 13:07

ComboBoxSearch: Add a new combo box control with filter/search

f7b92d4

ComboBoxSearch: Add mouse release ignore timer

01af59e

ComboBoxSearch: Draw separators

292c73d

owhierarchicalclustering: Use ComboSearchBox for 'Annotations'

676b81d

ComboBoxSearch: Improve focus tracking/proxying

e1e38ae

ComboBoxSearch: Implement popup list mouse tracking

4640e15

ComboBoxSearch: Use available desktop geometry, not the full screen

335758b

ComboBoxSearch: Extract dropdown_popup_geometry

f843270

ComboBoxSearch: Set focus policy

09619cd

ComboBoxSearch: Add tests

9d8e511

ComboBoxSearch: Do nothing on showPopup calles if popup already visible

56c3f7e

ComboBoxSearch: Remove use of WA_DoNotShowOnScreen

2308c37

Segfaults on headless xcb.

ComboBoxSearch: Change test_click test

10c45b7

Could segfault if the tested popup loses focus (is hidden and deleted) due to external factors. It is now run without any delay in the mouse event dispatch.

ComboBoxSearch: Fix popup hiding on Windows

b9acb4c

The popup does not appear to hide automatically on windows when a mouse button is pressed outside the popup window.

ComboBoxSearch: Remove event filters from popup widget on hide

e0ebb58

ComboBoxSearch: Improve event dispatch

5e41859

Remove special casing Home/End key filter, dispatch directly to the line edit with no event propagation up the parent chain.

ComboBoxSearch: Improve separator line styling

8b3e8a1

ales-erjavec force-pushed the combobox-search-filter branch from daec31b to 8b3e8a1 Compare August 9, 2018 11:24

lanzagar merged commit fdac69b into biolab:master Aug 10, 2018

ales-erjavec deleted the combobox-search-filter branch September 12, 2018 10:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ENH] Combo Box Search Filter#3014

[ENH] Combo Box Search Filter#3014
lanzagar merged 17 commits intobiolab:masterfrom
ales-erjavec:combobox-search-filter

ales-erjavec commented Apr 20, 2018

Uh oh!

BlazZupan commented Apr 20, 2018

Uh oh!

codecov-io commented Apr 23, 2018 •

edited

Loading

Uh oh!

ajdapretnar commented Jun 29, 2018

Uh oh!

thocevar left a comment

Uh oh!

thocevar Aug 3, 2018

Uh oh!

thocevar Aug 3, 2018

Uh oh!

lanzagar commented Aug 3, 2018

Uh oh!

ales-erjavec commented Aug 9, 2018

Uh oh!

thocevar commented Aug 10, 2018

Uh oh!

lanzagar commented Aug 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

ales-erjavec commented Apr 20, 2018

Issue

Description of changes

Includes

Uh oh!

BlazZupan commented Apr 20, 2018

Uh oh!

codecov-io commented Apr 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ajdapretnar commented Jun 29, 2018

Uh oh!

thocevar left a comment

Choose a reason for hiding this comment

Uh oh!

thocevar Aug 3, 2018

Choose a reason for hiding this comment

Uh oh!

thocevar Aug 3, 2018

Choose a reason for hiding this comment

Uh oh!

lanzagar commented Aug 3, 2018

Uh oh!

ales-erjavec commented Aug 9, 2018

Uh oh!

thocevar commented Aug 10, 2018

Uh oh!

lanzagar commented Aug 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-io commented Apr 23, 2018 •

edited

Loading