Skip to content

[FIX] gui: Suppress mouse button release on the combo box popup#3025

Merged
astaric merged 1 commit intobiolab:masterfrom
ales-erjavec:combo-box-popup-block-mouse-release
May 25, 2018
Merged

[FIX] gui: Suppress mouse button release on the combo box popup#3025
astaric merged 1 commit intobiolab:masterfrom
ales-erjavec:combo-box-popup-block-mouse-release

Conversation

@ales-erjavec
Copy link
Contributor

Issue

The QComboBox popup sometimes hides immediately after being displayed. For this to happen the model displayed in the combo box must be sufficiently large and/or slow so that the popup display is somewhat delayed (QTBUG-67583).

Description of changes

Implement a workaround for QTBUG-67583

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the combo-box-popup-block-mouse-release branch from 826ec94 to 857ff5b Compare May 8, 2018 13:24
@codecov-io
Copy link

codecov-io commented May 8, 2018

Codecov Report

Merging #3025 into master will increase coverage by 0.24%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master    #3025      +/-   ##
==========================================
+ Coverage   82.19%   82.43%   +0.24%     
==========================================
  Files         335      335              
  Lines       57688    58593     +905     
==========================================
+ Hits        47417    48302     +885     
- Misses      10271    10291      +20

@astaric astaric merged commit a7b5c63 into biolab:master May 25, 2018
@ales-erjavec ales-erjavec deleted the combo-box-popup-block-mouse-release branch May 29, 2018 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants