[FIX] owselectcolumns: Fix performance on filtering with selection#3030
Merged
lanzagar merged 1 commit intobiolab:masterfrom May 16, 2018
Merged
Conversation
83cd322 to
fe007c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3030 +/- ##
==========================================
+ Coverage 82.19% 82.21% +0.01%
==========================================
Files 335 335
Lines 57688 57683 -5
==========================================
+ Hits 47417 47422 +5
+ Misses 10271 10261 -10 |
fe007c7 to
b1bf6cc
Compare
Contributor
|
Improves filtering, but just to ask - how hard would it be to speed up drag and drop too? Dragging all features to Available in geo-gds360 takes a looong time. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Select Attributes has severe performance degradation on filtering a long list of variables (in the Available view) when all the variables are selected.
For example:
File ('geo-gds360') -> Select Attributes
move all variables to Available view, press Ctrl + A and enter any text in the Filter
Description of changes
update_interface_stateusing a single shot timer.Includes