[FIX] test_owmosaic: Cleanup/join threads on test tear down#3040
Merged
astaric merged 1 commit intobiolab:masterfrom May 24, 2018
Merged
[FIX] test_owmosaic: Cleanup/join threads on test tear down#3040astaric merged 1 commit intobiolab:masterfrom
astaric merged 1 commit intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3040 +/- ##
=========================================
Coverage ? 82.31%
=========================================
Files ? 335
Lines ? 57758
Branches ? 0
=========================================
Hits ? 47541
Misses ? 10217
Partials ? 0 |
Member
|
Nice catch. How did you figure it out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
VizRank tests for OWMosaic leave threads running after test completion influencing other tests via reduced performance and resulting TimeoutErrors.
For instance, run in bash:
$ python -m unittest Orange.widgets.visualize.tests.test_owmosaic.MosaicVizRankTests{,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,}Description of changes
Cleanup/join threads on test tear down
Includes