[ENH] Save data with compression#3047
Merged
BlazZupan merged 5 commits intobiolab:masterfrom Jun 13, 2018
Merged
Conversation
Contributor
lanzagar
commented
Jun 1, 2018
- Saving with compression was prevented due to a file format extension check that used only the last extension (in e.g. file.tab.gz)
- Compression was not supported when saving and loading in pickle format
- Changed default extension for PickleReader from .pickle to the shorter .pkl (both were supported before and still are).
This allows saving with compression (again?) by specifying extensions like .tab.gz and similar.
Contributor
|
Works as intended on Mac. Nice :-). |
Codecov Report
@@ Coverage Diff @@
## master #3047 +/- ##
==========================================
+ Coverage 82.37% 82.38% +<.01%
==========================================
Files 335 335
Lines 57812 57973 +161
==========================================
+ Hits 47622 47759 +137
- Misses 10190 10214 +24 |
Contributor
Author
|
I improved the OSX workaround (compression extensions were repeated), Should work on all platforms now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.