Skip to content

[ENH] Save data with compression#3047

Merged
BlazZupan merged 5 commits intobiolab:masterfrom
lanzagar:save-compression
Jun 13, 2018
Merged

[ENH] Save data with compression#3047
BlazZupan merged 5 commits intobiolab:masterfrom
lanzagar:save-compression

Conversation

@lanzagar
Copy link
Copy Markdown
Contributor

@lanzagar lanzagar commented Jun 1, 2018

  1. Saving with compression was prevented due to a file format extension check that used only the last extension (in e.g. file.tab.gz)
  2. Compression was not supported when saving and loading in pickle format
  3. Changed default extension for PickleReader from .pickle to the shorter .pkl (both were supported before and still are).

@BlazZupan
Copy link
Copy Markdown
Contributor

Works as intended on Mac. Nice :-).

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 1, 2018

Codecov Report

Merging #3047 into master will increase coverage by <.01%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master    #3047      +/-   ##
==========================================
+ Coverage   82.37%   82.38%   +<.01%     
==========================================
  Files         335      335              
  Lines       57812    57973     +161     
==========================================
+ Hits        47622    47759     +137     
- Misses      10190    10214      +24

@lanzagar
Copy link
Copy Markdown
Contributor Author

lanzagar commented Jun 1, 2018

I improved the OSX workaround (compression extensions were repeated),
and used it on windows as well (although .gz worked after another extension, .xz and .bz2 did not).

Should work on all platforms now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants