Skip to content

[FIX] BSD compatibility patch#3061

Merged
lanzagar merged 1 commit intobiolab:masterfrom
yurivict:master
Jun 11, 2018
Merged

[FIX] BSD compatibility patch#3061
lanzagar merged 1 commit intobiolab:masterfrom
yurivict:master

Conversation

@yurivict
Copy link
Contributor

Issue
Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #3061 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3061   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         335      335           
  Lines       57986    57986           
=======================================
  Hits        47774    47774           
  Misses      10212    10212

@lanzagar
Copy link
Contributor

Although we don't really support BSD (not included in any of our test suites), I don't mind a few fixes if that is all it takes to make it work. I would not be surprised, however, if there are problems elsewhere too...

Thanks for the patch!

@lanzagar lanzagar changed the title BSD compatibility patch [FIX] BSD compatibility patch Jun 11, 2018
@lanzagar lanzagar merged commit c5cc661 into biolab:master Jun 11, 2018
@yurivict
Copy link
Contributor Author

I would not be surprised, however, if there are problems elsewhere too...

I've created the FreeBSD port for Orange. It launches fine, although I didn't test it in-depth.

Yuri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants