[FIX] Canvas: Fix 'Widgest on top'#3068
Merged
astaric merged 4 commits intobiolab:masterfrom Jun 15, 2018
Merged
Conversation
On some platforms setting window flags and/or hide/show implicitly triggers application deactivate/reactivate, triggering an endless back and forth state changes.
ales-erjavec
force-pushed
the
fixes/always-on-top
branch
from
f529f93 to
d4cdf78
Compare
Codecov Report
@@ Coverage Diff @@
## master #3068 +/- ##
==========================================
+ Coverage 82.38% 82.38% +<.01%
==========================================
Files 335 335
Lines 57990 57990
==========================================
+ Hits 47775 47776 +1
+ Misses 10215 10214 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
On some platforms (Windows, Gnome) setting window flags and/or hide/show implicitly triggers
application deactivate/reactivate, triggering an endless back and forth
state changes. This can outright seemingly freeze desktop shell.
Description of changes
Remove window flags modification on application state change.
Includes