[FIX] utils/concurrent: Switch default thread pool#3138
Merged
thocevar merged 1 commit intobiolab:masterfrom Jul 30, 2018
Merged
[FIX] utils/concurrent: Switch default thread pool#3138thocevar merged 1 commit intobiolab:masterfrom
thocevar merged 1 commit intobiolab:masterfrom
Conversation
The default stack size of QThreadPool created threads on BSD or BSD derived systems is insufficient to call OpenBLAS in common builds (see numpy issue 11551).
Contributor
|
ThreadExecutor doesn't seem to fully utilize the CPU. Execution time is the same with 1 or 4 max_workers on a 4-core CPU (Windows 10). Are the threads assigned to the same core? |
Contributor
Author
|
Where? What task? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-3079, gh-3050
Description of changes
The default stack size of QThreadPool created threads is insufficient
to call OpenBLAS in common builds (see numpy issue 11551).
Includes