[FIX][RFC] KMeans upgrade sparse support#3140
Merged
ajdapretnar merged 5 commits intobiolab:masterfrom Jul 24, 2018
Merged
Conversation
Contributor
|
Would you mind adding a nice informative error when the user connects pure Corpus into k-Means (without bag of words)? Now the error is useless. It should say something like: "Data has no attributes." or "Data is missing features." |
Collaborator
Author
|
@ajdapretnar I can add it but this pull request is probably not the right place for it. |
Contributor
|
Ok, let's have it in a different PR then. As far as I am concerned, this PR works. |
3 tasks
Contributor
|
Would you mind making pylint happy, so the tests will pass? :) 🙈
|
Codecov Report
@@ Coverage Diff @@
## master #3140 +/- ##
=======================================
Coverage 82.33% 82.33%
=======================================
Files 335 335
Lines 58180 58180
=======================================
Hits 47901 47901
Misses 10279 10279 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2913
Additionally, I noticed that you can not predict sparse data.
Description of changes
Replaced
len(X)withX.shape[0].Includes