[FIX] OWBoxPlot: Fix quartiles computation#3159
Merged
ajdapretnar merged 1 commit intobiolab:masterfrom Jul 30, 2018
Merged
Conversation
The code assumed that all quartiles would (or need to) be distinct. Replace the linear scan with a numpy implementation.
ales-erjavec
force-pushed
the
fixes/box-plot-quantiles
branch
from
c5eb7fc to
b94b892
Compare
Codecov Report
@@ Coverage Diff @@
## master #3159 +/- ##
==========================================
+ Coverage 82.37% 82.37% +<.01%
==========================================
Files 336 336
Lines 58303 58320 +17
==========================================
+ Hits 48025 48041 +16
- Misses 10278 10279 +1 |
ajdapretnar
approved these changes
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Ref gh-1737
Fix quartiles computation
The code assumed that all quartiles would (or need to) be distinct.
Description of changes
Replace the linear scan in BoxPlot constructor with a numpy based implementation.
Includes