[ENH] Scatterplot: indicate overlap of points.#3177
Merged
astaric merged 6 commits intobiolab:masterfrom Aug 24, 2018
Merged
Conversation
d5cb3ba to
a634455
Compare
Codecov Report
@@ Coverage Diff @@
## master #3177 +/- ##
==========================================
- Coverage 82.74% 82.74% -0.01%
==========================================
Files 344 344
Lines 59323 59328 +5
==========================================
Hits 49088 49088
- Misses 10235 10240 +5 |
Contributor
|
For me the updated scatter plot looks a bit confusing, since it states 'Same size', but there appear to be points of different sizes. |
Contributor
|
I agree. Adding an option to Size would make a lot of sense! |
a634455 to
a1f81e9
Compare
9b3e7a4 to
a03e6ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Implements #3028
Description of changes
Scatterplot computes the set of indices at each coordinate for later use in compute_sizes and compute_colors. The sizes are multiplied by log_2 of the number of points. The color represents the most frequent color (or one of them if there are several).
Includes