[FIX] Documentation fetching with redirects#3248
Merged
astaric merged 1 commit intobiolab:masterfrom Sep 13, 2018
Merged
Conversation
markotoplak
force-pushed
the
fix-doc-redir
branch
from
91562d1 to
d26874a
Compare
Member
|
How can we test this? Which add-ons were problematic? |
Member
Author
|
Test with imageanalytics that is installed with "pip install -e ." (and where doc was not built). |
Member
|
I did, and it works even when using the current master. The log says Using PyQt 5.9.2 on mac |
Member
Author
|
Does clicking on the widget and pressing F1 show the documentation? |
Member
|
Yes, it does |
Member
|
I have managed to break it on master, and after applying the fix it started working again |
markotoplak
force-pushed
the
fix-doc-redir
branch
from
d26874a to
702b9fd
Compare
markotoplak
force-pushed
the
fix-doc-redir
branch
from
702b9fd to
4a9fee6
Compare
astaric
approved these changes
Sep 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#3247
Description of changes
Follow redirects if Qt supports it.
Includes