[FIX] OWWidget: Preserve widget geometry between hide/show events#3304
Merged
janezd merged 1 commit intobiolab:masterfrom Oct 19, 2018
Merged
[FIX] OWWidget: Preserve widget geometry between hide/show events#3304janezd merged 1 commit intobiolab:masterfrom
janezd merged 1 commit intobiolab:masterfrom
Conversation
The fix from biolabgh-2027 did not execute when the widget had no existing saved geometry to restore (i.e. on first use or after 'Reset Widget Settings' was run).
ales-erjavec
force-pushed
the
fixes/first-show
branch
from
11d9df6 to
e529f57
Compare
Codecov Report
@@ Coverage Diff @@
## master #3304 +/- ##
==========================================
+ Coverage 82.57% 82.58% +<.01%
==========================================
Files 348 348
Lines 61395 61396 +1
==========================================
+ Hits 50697 50701 +4
+ Misses 10698 10695 -3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-3240
The fix from gh-2027 did not execute when the widget had no existing
saved geometry to restore (i.e. on first use or after 'Reset Widget
Settings' was run).
Description of changes
Move the gh-2027 code to
showEventand execute it always on first show event.Includes