[FIX] Predictions: Fix failure after failed predictor#3337
Merged
lanzagar merged 1 commit intobiolab:masterfrom Nov 7, 2018
Merged
[FIX] Predictions: Fix failure after failed predictor#3337lanzagar merged 1 commit intobiolab:masterfrom
lanzagar merged 1 commit intobiolab:masterfrom
Conversation
a6498bb to
62bc1ce
Compare
3 tasks
62bc1ce to
2a3adca
Compare
Codecov Report
@@ Coverage Diff @@
## master #3337 +/- ##
==========================================
+ Coverage 82.21% 82.27% +0.06%
==========================================
Files 351 351
Lines 62301 62575 +274
==========================================
+ Hits 51219 51485 +266
- Misses 11082 11090 +8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
I predictor fails, it sets results to a string describing an error. When
_call_predictorsis called again, it tests forpred.results is None or numpy.isnan(pred.results[0]).all(), which crashes becausepred.resultsis a string.Description of changes
Test for
isinstance(pred.results, str)and treat it asNoneor all nans.Includes