[ENH] Transform: Add new widget#3346
Conversation
janezd
left a comment
janezd
left a comment
There was a problem hiding this comment.
After you decide about the suggestion about handling the exception, I'd merge it unless @BlazZupan has any further comments.
Orange/widgets/data/owtransform.py
Outdated
| def apply(self): | ||
| self.transformed_data = None | ||
| if self.data is not None and self.preprocessor is not None: | ||
| self.transformed_data = self.preprocessor(self.data) |
There was a problem hiding this comment.
Preprocessor could raise an exception here. I think the widget has to catch and report it. Maybe something like "An error occurred while transforming data", and the second line (visible only on tooltip) would contain the exception message.
Codecov Report
@@ Coverage Diff @@
## master #3346 +/- ##
==========================================
+ Coverage 82.21% 82.26% +0.04%
==========================================
Files 351 353 +2
Lines 62349 62513 +164
==========================================
+ Hits 51262 51426 +164
Misses 11087 11087 |
|
Works as intended. Therefore merge. The documentation and subsequently a blog, once the widget enters the distribution, are missing. Also, for testing, could we release both widgets (PCA, Transform) into Prototypes (change name to, say, Test PCA, and Test Transform)? |
4 participants
Issue
Implements #3342
Description of changes
Includes