[ENH] Correlations: Move from prototypes to core#3362
Merged
lanzagar merged 2 commits intobiolab:masterfrom Nov 12, 2018
Merged
[ENH] Correlations: Move from prototypes to core#3362lanzagar merged 2 commits intobiolab:masterfrom
lanzagar merged 2 commits intobiolab:masterfrom
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #3362 +/- ##
=========================================
+ Coverage 82.26% 82.3% +0.04%
=========================================
Files 351 353 +2
Lines 62450 62755 +305
=========================================
+ Hits 51372 51652 +280
- Misses 11078 11103 +25 |
VesnaT
force-pushed
the
correlations
branch
3 times, most recently
from
d1daaf8 to
898ea2d
Compare
VesnaT
force-pushed
the
correlations
branch
2 times, most recently
from
39e16ae to
b566591
Compare
Contributor
|
Add Correlations widget (without input) -> press Start -> crash |
Contributor
|
I think the button should be disabled when no input. It is disabled after changing the correlation but not when the widget is placed at the canvas. |
lanzagar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Includes